[root.exe] Use non-zero exit status when invalid arguments are passed #19196
+7
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hageboeck
requested review from
bellenot,
couet,
dpiparo and
pcanal
as code owners
hageboeck
force-pushed
the
root_exitStatus
branch
from
f8f008e to
c177567
Compare
vepadulano
reviewed
Jun 26, 2025
pcanal
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
LGTM.
Side note: The RUFF does not seem to handle well deleted files, see:
https://github.com/root-project/root/actions/runs/15901873603/job/44846574695?pr=19196
which says:
Run files=$(cat changed_files.txt | grep '\.py$' || echo "")
Error: tutorials/.enableImplicitMTWrapper.py:1:1: E902 No such file or directory (os error 2)
Error: Process completed with exit code 123.
Test Results 20 files 20 suites 3d 11h 41m 11s ⏱️ For more details on these failures, see this check. Results for commit a07f891. ♻️ This comment has been updated with latest results. |
@pcanal I had noticed the same, but this problem was fixed in the mean time here: #19197 |
hageboeck
force-pushed
the
root_exitStatus
branch
from
c177567 to
4720fd7
Compare
silverweed
reviewed
Jul 2, 2025
This invocation root.exe "-e EnableImplicitMT(4)" (single argument instead of two) broke the IMT tutorials, but went undetected. Here, we set the exit status to 2 if root.exe's arguments could not be parsed correctly. (When the interpreter command fails, the exit status is set to 1, so these two cases can be told apart.) Since the executable now exits with a non-zero status, the test had to be pulled out of gtest, and is now split into one that tests the exit status and one that checks the error message.
hageboeck
force-pushed
the
root_exitStatus
branch
from
4720fd7 to
a07f891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #19195:
RDF IMT tutorials didn't run since 10 months, since the following passed with a 0 exit status:
To avoid similar problem in the future, I suggest here to exit with a non-zero exit status. I chose 2 because 1 usually means that the script/macro/command that was running in the interpreter failed:
Whereas a failure to parse the argument would now be: