Deprecate Snapshot template #19201
Merged
Deprecate Snapshot template #19201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vepadulano
requested review from
bellenot,
martamaja10,
couet,
pcanal and
dpiparo
as code owners
vepadulano
force-pushed
the
rdf-deprecate-snapshot-template
branch
3 times, most recently
from
f4415b9 to
2b8c62e
Compare
vepadulano
force-pushed
the
rdf-deprecate-snapshot-template
branch
2 times, most recently
from
356cfd7 to
abcfca9
Compare
|
Is this ready for review? The commit starts with |
vepadulano
force-pushed
the
rdf-deprecate-snapshot-template
branch
from
abcfca9 to
7920e07
Compare
|
Thank you @pcanal , the changes are indeed ready for review, the commit message has been updated accordingly. |
vepadulano
changed the title
pcanal
reviewed
Jun 26, 2025
pcanal
approved these changes
Jun 26, 2025
hageboeck
approved these changes
Jun 27, 2025
martamaja10
approved these changes
Jun 27, 2025
* ROOT::Internal::RDF::AddSizeBranches was never considering the possibility of a
column being a leaf coming from an in-memory struct stored via a leaflist (i.e.
`struct A { int a; int b;}` stored via `Branch("br", &br, "a/I:b/I")`). In such
cases, there is no extra size branch to add so the function now skips this type
of column
* The bufSize and splitLevel arguments to various Branch calls were
not considering the related values of the input branch if it exists.
* A specific scenario with a Redefine changing the type of the column to
Snapshot from a C-style array stored with a leaflist to a ROOT::RVec was still
storing the value as C-style array in the output TTree. Now, when a column value
is coming from a define, the CreateCStyleArrayBranch path is never taken, as it
is not allowed to create C-style array columns from defines.
* The case of an input TTree branch containing unsplit objects of polymorphic
types was not considered in SetBranchesHelper and is now added.
Now that Snapshot does not require knowledge about column types at compile-time, we can deprecate the Snapshot template overload. The deprecation starts now, targeting complete removal of the overload in version 6.40. All the functionality connected to that overload is removed from the codebase.
To avoid subtle errors
* Move all definitions (except trivial ones) to implementation file * Remove many includes * Fix many places which were relying on parasitic includes
vepadulano
force-pushed
the
rdf-deprecate-snapshot-template
branch
from
7920e07 to
c238d99
Compare
|
Thank you all for the reviews! I have split the changes in multiple commits to make the history clearer |
|
@vepadulano I forgot one thing: This very much deserves to be in the release notes for 6.38! |
hageboeck
reviewed
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.