Skip to content

[skip-ci] Create histv7, document terminology and design #19213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 2, 2025
Merged

[skip-ci] Create histv7, document terminology and design #19213

merged 4 commits into from
Jul 2, 2025

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Jun 27, 2025

No description provided.

hahnjo added 2 commits June 27, 2025 12:40
@hahnjo
[hist] Remove outdated comments in CMakeLists.txt
fd82076
@hahnjo
[hist] Create directory for new histograms
d572af8 
Design documents and the implementation will be added over time.
@hahnjo hahnjo self-assigned this Jun 27, 2025
@hahnjo hahnjo requested a review from bellenot as a code owner June 27, 2025 11:05
@hahnjo hahnjo added the in:Hist label Jun 27, 2025
@hahnjo hahnjo requested review from lmoneta and dpiparo as code owners June 27, 2025 11:05
hageboeck
hageboeck reviewed Jun 27, 2025
View reviewed changes
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, LGTM!

Of the comments I added, the "flow bins" are my biggest concern.

jblomer
jblomer approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Very good starting point.

siliataider
siliataider approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@siliataider siliataider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great start to unify the terminology, thanks!

@hahnjo hahnjo merged commit 0d2aa0e into root-project:master Jul 2, 2025
7 checks passed
@hahnjo hahnjo deleted the hist-doc branch July 2, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblomer jblomer jblomer approved these changes

@hageboeck hageboeck hageboeck left review comments

@siliataider siliataider siliataider approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@lmoneta lmoneta Awaiting requested review from lmoneta

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

Assignees

@hahnjo hahnjo

Labels
in:Hist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hahnjo @jblomer @hageboeck @siliataider