Remove seemingly illogical code in rootcp
#19214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is this weird check in `rootcp --replace` where a possibly existing object in the destination file is only deleted if it is not equal (`==`) to the object in the source file. The default equality check for TObjects is to compare by pointer, so this condition can never be false and the existing is always deleted, as one would expect from the `--replace` option. The object would only *not* be replaced if the class overrides `operator==` and both `otherObj` and `obj` are the same. But why not deleting the existing object if it's the same anyway? To me, this check doesn't make sense and this commit suggests to always delete the existing object, as the user would expect when passing the `--replace` option to `rootcp`. Closes root-project#19035.
vepadulano
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is this weird check in
rootcp --replacewhere a possibly existing object in the destination file is only deleted if it is not equal (==) to the object in the source file.The default equality check for TObjects is to compare by pointer, so this condition can never be false and the existing is always deleted, as one would expect from the
--replaceoption.The object would only not be replaced if the class overrides
operator==and bothotherObjandobjare the same. But why not deleting the existing object if it's the same anyway?To me, this check doesn't make sense and this commit suggests to always delete the existing object, as the user would expect when passing the
--replaceoption torootcp.Closes #19035.