[6.36][ntuple] Merger: fix bugs in GenerateZeroPagesForColumns #19215
+72
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- nElements was used to grow each zero page instead of nElementsPerPage - only the last zero page was added to the page groups (cherry picked from commit e9b81c8)
Test Results 19 files 19 suites 3d 7h 42m 17s ⏱️ For more details on these failures, see this check. Results for commit d89684d. |
pcanal
approved these changes
Jun 27, 2025
silverweed
merged commit fd5fc14
into
root-project:v6-36-00-patches
20 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BP of #19198