[CMake] Set CMAKE_OSX_SYSROOT only if CMake generator is Xcode
#19218
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set `CMAKE_OSX_SYSROOT` only if CMake generator is Xcode, because otherwise we don't need it. Also, if not using Xcode ,the `xcrun` executable that is used to figure out this variable is also not available, leading to configuration failues when building ROOT on macOS without Xcode installed. Follows up on 6bd0dba and ebc38bd.
guitargeek
added
in:Build System
clean build
pcanal
reviewed
Jun 27, 2025
| @@ -12,7 +12,7 @@ if(WIN32) | |||
| cmake_policy(SET CMP0091 OLD) | |||
| set(CMAKE_SKIP_TEST_ALL_DEPENDENCY TRUE) | |||
| endif() | |||
| if(APPLE AND (NOT CMAKE_OSX_SYSROOT OR CMAKE_OSX_SYSROOT STREQUAL "")) | |||
| if((CMAKE_GENERATOR MATCHES Xcode) AND (NOT CMAKE_OSX_SYSROOT OR CMAKE_OSX_SYSROOT STREQUAL "")) | |||
There was a problem hiding this comment.
Is it really dependent of the Generator or is it the compiler (XCode's clang)? (eg I use Ninja+XCode's clang).
There was a problem hiding this comment.
I don't know, but you have the perfect setup to figure this out then! Does this PR build for you? If not, it's the compiler and I need to put a check for Apple Clang there. Can you give a hand by doing this check?
There was a problem hiding this comment.
So form a fresh directory, with your commit, it seems to work ... but then again it is still 'set':
mac-142865:osxroot pcanal$ rg -C3 CMAKE_OSX_SYSROOT CMakeCache.txt
475-
476-//The product will be built against the headers and libraries located
477-// inside the indicated SDK.
478:CMAKE_OSX_SYSROOT:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.5.sdk
479-
Test Results 20 files 20 suites 3d 5h 31m 57s ⏱️ For more details on these failures, see this check. Results for commit bb1035d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
CMAKE_OSX_SYSROOTonly if CMake generator is Xcode, because otherwise we don't need it. Also, if not using Xcode ,thexcrunexecutable that is used to figure out this variable is also not available, leading to configuration failures when building ROOT on macOS without Xcode installed.Follows up on 6bd0dba and ebc38bd.