Align behaviour of SetBranchStatus of TChain and TTree #19221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcanal
reviewed
Jun 27, 2025
pcanal
reviewed
Jun 27, 2025
When a user calls SetBranchStatus("*", false) it means that all branches of the
dataset should be deactivated, no matter what other method is called, except if
then the user calls SetBranchStatus(someBranch, true) to activate a branch.
So, if a user calls SetBranchStatus to deactivate all branches and then calls
SetBranchAddress, this should have no effect. No data should be read because the
branch related to SetBranchAddress should not have been activated.
Before this commit, TTree was respecting this rule, but TChain was not. This
commit ensures that TChain only sets the status of the branch of the current
TTree if the corresponding TChainElement was explicitly provided with a status
by the user.
Test Results 20 files 20 suites 3d 4h 38m 38s ⏱️ For more details on these failures, see this check. Results for commit 2699e55. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user calls SetBranchStatus("*", false) it means that all branches of the dataset should be deactivated, no matter what other method is called, except if then the user calls SetBranchStatus(someBranch, true) to activate a branch.
So, if a user calls SetBranchStatus to deactivate all branches and then calls SetBranchAddress, this should have no effect. No data should be read because the branch related to SetBranchAddress should not have been activated.
Before this commit, TTree was respecting this rule, but TChain was not. This commit ensures that TChain only sets the status of the branch of the current TTree if the corresponding TChainElement was explicitly provided with a status by the user.
Fixes #19220