[cppyy] Correct management of GIL in concurrency tests #19237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
issue-19224
branch
2 times, most recently
from
ecc4448 to
e7835ab
Compare
Test Results 20 files 20 suites 3d 6h 6m 6s ⏱️ Results for commit eff7147. ♻️ This comment has been updated with latest results. |
Vipul-Cariappa
requested changes
Jul 1, 2025
There was a problem hiding this comment.
I guess the changes require PyGILState_Ensure & PyGILState_Release.
Reference: https://docs.python.org/3/c-api/init.html#non-python-created-threads
The GIL should always be acquired via the thread state API when doing Python calls from multithreaded C++. Fixes the test failure with Python debug builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GIL should always be acquired via the thread state API when doing Python calls from multithreaded C++.
Fixes the test failure with Python debug builds.