[636] [clang] Fix two RAIIs for recursive parsing #19244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CachedTokens comes before CachedLexPos in Preprocessor. (cherry picked from commit 5ecad6e)
Found while investigating root-project#18972 Co-authored-by: silverweed <giacomo.parolini@cern.ch> (cherry picked from commit 3fc840d)
FunctionScopesStart and InventedParameterInfosStart were introduced by upstream commit llvm/llvm-project@5c845c1 and are handled in ContextRAII, but not our ContextAndScopeRAII. (cherry picked from commit b702391, it was lost during the upgrade to LLVM 18)
(cherry picked from commit 07021ea, it was lost during the upgrade to LLVM 18)
Test Results 19 files 19 suites 3d 5h 55m 3s ⏱️ Results for commit d8ce5b7. ♻️ This comment has been updated with latest results. |
vgvassilev
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BP of #19137