[cling] Check if LLVM_SUBMIT_VERSION is defined, not its value

[aaronj0]

Reported here: root-project/cling#551
We check if a variable exists named with the value of LLVM_SUBMIT_VERSION instead of checking if it is defined.

[vgvassilev]

LGTM!

[github-actions]

Test Results

    20 files      20 suites   3d 7h 10m 10s ⏱️
 3 115 tests  3 114 ✅ 0 💤 1 ❌
60 699 runs  60 696 ✅ 2 💤 1 ❌

For more details on these failures, see this check.

Results for commit 636d20d.

♻️ This comment has been updated with latest results.

[hahnjo]

The latest version doesn't check anymore that the variable is DEFINED. Is that intentional, what is the use case for the variable? Also interpreter/cling/tools/Jupyter/CMakeLists.txt has the same pattern and should be fixed at the same time.

[aaronj0]

The latest version doesn't check anymore that the variable is DEFINED.
Also interpreter/cling/tools/Jupyter/CMakeLists.txt has the same pattern and should be fixed at the same time.

Thanks, that was an oversight there, that should not be a not false check and retain DEFINED. I have addressed that and replaced the pattern in Jupyter.

what is the use case for the variable

Based on my limited knowledge when I looked into this issue, this is used for a shared build with LLVM built the "apple way" way (perhaps no longer used?) which uses some autoconf build recipe as seen in llvmCore. As a part of that we pass the llvmCore submission number as a link flag.

[aaronj0]

Failures on debian are unrelated and can be seen on master: https://github.com/root-project/root/actions/runs/16028087965/job/45221169747