Skip to content

[roottest] cmake for io [part3] #19252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 3, 2025
Merged

[roottest] cmake for io [part3] #19252

merged 10 commits into from
Jul 3, 2025

Conversation

linev
Copy link
Member

@linev linev commented Jul 2, 2025

Using cmake in:

  • io/heritstl
  • io/ignoreobject
  • io/interface
  • io/issue-7754
  • io/issue-9899
  • io/longlong
  • io/multizip
  • io/namespacedict

@linev linev requested a review from pcanal July 2, 2025 10:11
@linev linev self-assigned this Jul 2, 2025
@linev linev requested review from bellenot and dpiparo as code owners July 2, 2025 10:11
pcanal
pcanal reviewed Jul 2, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2025 •
edited
Loading

Test Results

    20 files      20 suites   3d 9h 41m 58s ⏱️
 3 129 tests  3 129 ✅ 0 💤 0 ❌
60 985 runs  60 985 ✅ 0 💤 0 ❌

Results for commit 2053b8a.

♻️ This comment has been updated with latest results.

pcanal
pcanal approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@pcanal
Copy link
Member

pcanal commented Jul 2, 2025

The test failure https://github.com/root-project/root/actions/runs/16022317759/job/45201995935?pr=19252 is likely introduce/related to the change of which node does the dev=ON.

@ferdymercury
Copy link
Collaborator

The test failure https://github.com/root-project/root/actions/runs/16022317759/job/45201995935?pr=19252 is likely introduce/related to the change of which node does the dev=ON.

Fix here: #19264

@ferdymercury
Copy link
Collaborator

ferdymercury commented Jul 3, 2025 •
edited
Loading

Unrelated comment to @linev:
Thanks for this awesome work!

Are you also planning to migrate these residual ones, that are outside of roottest?

gui/fitpanel/test/Makefile
math/genvector/test/Makefile
math/mathcore/test/fit/Makefile
math/smatrix/test/Makefile
test/histviewer/Makefile
test/Makefile*
test/periodic/Makefile
test/ProofBench/Makefile_event
test/rhtml/Makefile*
test/RootIDE/Makefile*
test/RootShower/Makefile*

@linev @pcanal
[roottest] update commen in io/ignoretobject/A.C
2053b8a 
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
@linev
Copy link
Member Author

linev commented Jul 3, 2025

@ferdymercury

There are still several PRs opened.
Most of them are for tests in root/io/.
Plus separate PR for the libEvent - #19173
But I will be in vacations starting from 5th of July.

@linev linev merged commit 0588853 into root-project:master Jul 3, 2025
24 of 25 checks passed
@linev linev deleted the roottest_io_part3 branch July 3, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

Assignees

@linev linev

Labels
affects:master in:I/O in:Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linev @pcanal @ferdymercury