[eve7] fix GlViewerJSRoot and GlViewerThree #19263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many members in geometry painter are private now and should be accessed via the getter methods
When JSROOT geometry painter will be used, one can access geometry description directly and provide it to the geometry painter. This allows correctly rebuild geometry hierarchy
If geometry size is too big, distance will be too large and no any display appears
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit aa2200e. ♻️ This comment has been updated with latest results. |
Upgrade three.js to r177 Several small fixes in TGeoPainter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using TGeoPainter in GlViewerJSRoot,
process geometry description data as is - 3D objects building remains inside painter
This let use navigation and interactivity from TGeoPainter again
Set near/far parameters in PerspectiveCamera of GlViewerThree
If geometry size significantly bigger than default 1000 - camera will not be able to "see" such object
Update JSROOT with several geopainter fixes and three.js r177