Implement redirect (#5) (#30)

Author: AkiaCode

python/http.py

@@ -62,7 +62,7 @@ def _get_headers_and_body(sock, host, port, path):
         version, status, explanation = line.split(" ", 2)
 
         # 9. Check status
-        assert status == "200", f"{status}: {explanation}"
+        assert status in ("200", "301", "302"), f"{status}: {explanation}"
 
         # 10. Parse headers
         headers = {}
@@ -73,6 +73,9 @@ def _get_headers_and_body(sock, host, port, path):
             header, value = line.split(":", 1)
             headers[header.lower()] = value.strip()
 
+        if "location" in headers:
+            return request(headers["location"])
+
         if "transfer-encoding" in headers:
             encoding = headers["transfer-encoding"]
             if encoding == "chunked":

python/tests/test_http.py

@@ -32,6 +32,16 @@ def test_lex(self):
         ret = lex(origin)
         self.assertEqual(ret, " test ")
 
+    def test_redirect(self):
+        redirect_sites = [
+            "http://www.naver.com/",
+            "http://browser.engineering/redirect",
+        ]
+        for site in redirect_sites:
+            headers, body = request(site)
+            self.assertGreater(len(body), 0)
+            self.assertIn("content-type", headers)
+
 
 if __name__ == "__main__":
     unittest.main()

rust/src/lib.rs

@@ -180,7 +180,7 @@ pub mod http {
 
         // 9. Check status
         match status {
-            "200" => (),
+            "200" | "301" | "302" => (),
             _ => panic!("{}: {}", status, explanation),
         };
 
@@ -200,6 +200,10 @@ pub mod http {
             headers.insert(header, value.to_string());
         }
 
+        if let Some(url) = headers.get("location") {
+            return request(url);
+        }
+
         let content_encoding: ContentEncoding = match headers.get("content-encoding") {
             Some(encoding) => encoding.parse().map_err(|_| UNSUPPORTED_ENCODING)?,
             None => ContentEncoding::Identity,
@@ -447,4 +451,18 @@ mod tests {
         assert_eq!(http::lex(origin.as_bytes()), " test ");
         Ok(())
     }
+
+    #[test]
+    fn test_redirect() -> Result<(), String> {
+        let redirect_sites = vec![
+            "http://www.naver.com/",
+            "http://browser.engineering/redirect",
+        ];
+        for site in redirect_sites {
+            let (header, body) = http::request(site).unwrap();
+            assert!(header.contains_key("content-type"));
+            assert!(!body.is_empty());
+        }
+        Ok(())
+    }
 }