Skip to content

Only show body content #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2021
Merged

Only show body content #27

merged 2 commits into from
Apr 27, 2021

Conversation

yihyunjoon
Copy link
Contributor

Screen Shot 2021-04-25 at 2 54 32 AM

@yihyunjoon
Copy link
Contributor Author

#18

@corona10
Copy link
Contributor

corona10 commented Apr 25, 2021 •
edited
Loading

@corona10 corona10 self-requested a review April 25, 2021 04:54
youknowone
youknowone requested changes Apr 25, 2021
View reviewed changes
rust/src/lib.rs
Comment on lines +221 to +257
let mut out = String::new();
let mut tag = String::new();
Copy link
Contributor

@youknowone youknowone Apr 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because body is alive until the function end, out and tag don't need to be String but to be &[u8].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this on another branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow code review if possible in a single PR.

@yihyunjoon
Copy link
Contributor Author

Sure, I'll do it later.

I didn't add my name in README.md. I haven't decided what chapter to do yet.

Added!

Formatted the code. It will pass.

@corona10
Copy link
Contributor

I didn't add my name in README.md. I haven't decided what chapter to do yet.

This task is part of chapter 1

@corona10 corona10 merged commit 5fc88ed into rust-kr:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone

@corona10 corona10

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihyunjoon @corona10 @youknowone