Implement redirect (#5) #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
requested changes
May 2, 2021
corona10
reviewed
May 2, 2021
corona10
reviewed
May 2, 2021
corona10
requested changes
May 2, 2021
corona10
approved these changes
May 2, 2021
youknowone
requested changes
May 2, 2021
rust/src/lib.rs
Outdated
Comment on lines
203
to
206
| let redirect = headers.get("location").map(|url| request(url)); | ||
| if redirect.is_some() { | ||
| return redirect.unwrap(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| let redirect = headers.get("location").map(|url| request(url)); | |
| if redirect.is_some() { | |
| return redirect.unwrap(); | |
| } | |
| if let Some(redirect) = headers.get("location").map(request) { | |
| return redirect; | |
| } |
There was a problem hiding this comment.
Then, map(|url| request(url) please. The major goal is removnig unnessessary is_some() and unwrap()
There was a problem hiding this comment.
I now think request part must be in the body of the if block because request is a failable function in theory - though we are not handling it here. So a new suggestion is:
if let Some(url) = headers.get("location") {
return request(url);
}this is also equivalent to the python version.
rust/src/lib.rs
Outdated
| for site in redirect_sites { | ||
| let (header, body) = http::request(site).unwrap(); | ||
| assert_eq!(header.contains_key("content-type"), true); | ||
| assert_eq!(body.len() > 0, true); |
There was a problem hiding this comment.
Suggested change
| assert_eq!(body.len() > 0, true); | |
| assert!(header.contains_key("content-type")); | |
| assert!(!body.is_empty()); |
corona10
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5