Skip to content

cargo tests seems to not run by default on ./x test --stage 2 #141686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jieyouxu opened this issue May 28, 2025 · 0 comments
Open

cargo tests seems to not run by default on ./x test --stage 2 #141686

jieyouxu opened this issue May 28, 2025 · 0 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

It seems surprising that we don't yet run cargo's tests in CI for hosts by default (as part of ./x test) on stage 2

$ ./x test --dry-run --stage=2 | grep cargo
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.02s
Documenting stage2 cargo (x86_64-unknown-linux-gnu)
Doc path: /home/joe/repos/rust/build/tmp-dry-run/x86_64-unknown-linux-> gnu/doc/cargo/index.html
Building tool cargo (stage1 -> stage2, x86_64-unknown-linux-gnu)
Build completed successfully in 0:00:00

🤔

Yeah, e.g.

# x86_64-msvc-ext is split into multiple jobs to run tests in parallel.
- name: x86_64-msvc-ext1
env:
SCRIPT: python x.py --stage 2 test src/tools/cargotest src/tools/cargo

That seems weird

Originally posted by @jieyouxu in #141656 (comment)

I haven't looked into this yet, opening an issue to track.

@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 28, 2025
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-testsuite Area: The testsuite used to check the correctness of rustc and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

2 participants