-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Please stop using GITHUB_ACTION to change the behaviour of the build system #141813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
There is no need to introduce another ENV. You can prepare a patch that uses is_rust_lang_managed_ci_job instead of is_ci for cases where you think using GITHUB_ACTIONS doesn't make sense. |
download-ci-llvm is only meant for local development. If you use it in CI, your CI will break in a couple of months unless you regularly update rustc. The per-commit CI artifacts that download-ci-llvm downloads only get retained for a limited amount of time. |
We should straight-up advise setting |
#141782 🤷 |
Yes, that's because @lu-zero set it in the package file, so @smallprogram doesn't feel empowered to change it because they're not the maintainer of the package. |
Alternatively, if they don't want to compile LLVM for some reason and prefer to use a precompiled version, there is a better way. They can specify the path to [target.x86_64-unknown-linux-gnu]
llvm-config = "/path/to/llvm-config" Maybe we should include this in the error message. |
We could also forcefully set |
It causes surprising breakages openwrt/packages#26623 downstream.
If we can agree to use an env var like RUST_CI_IN_USE I'll prepare a patch.
The text was updated successfully, but these errors were encountered: