Skip to content

Please stop using GITHUB_ACTION to change the behaviour of the build system #141813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lu-zero opened this issue May 31, 2025 · 7 comments
Open
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@lu-zero
Copy link
Contributor

lu-zero commented May 31, 2025

It causes surprising breakages openwrt/packages#26623 downstream.

If we can agree to use an env var like RUST_CI_IN_USE I'll prepare a patch.

@lu-zero lu-zero added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels May 31, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 31, 2025
@onur-ozkan
Copy link
Member

There is no need to introduce another ENV. You can prepare a patch that uses is_rust_lang_managed_ci_job instead of is_ci for cases where you think using GITHUB_ACTIONS doesn't make sense.

@onur-ozkan onur-ozkan added C-discussion Category: Discussion or questions that doesn't represent real issues. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. C-bug Category: This is a bug. labels May 31, 2025
@bjorn3
Copy link
Member

bjorn3 commented May 31, 2025

download-ci-llvm is only meant for local development. If you use it in CI, your CI will break in a couple of months unless you regularly update rustc. The per-commit CI artifacts that download-ci-llvm downloads only get retained for a limited amount of time.

@workingjubilee
Copy link
Member

We should straight-up advise setting download-ci-llvm = false.

@onur-ozkan
Copy link
Member

We should straight-up advise setting download-ci-llvm = false.

#141782 🤷

@workingjubilee
Copy link
Member

Yes, that's because @lu-zero set it in the package file, so @smallprogram doesn't feel empowered to change it because they're not the maintainer of the package.

@onur-ozkan onur-ozkan marked this as a duplicate of #141782 May 31, 2025
@onur-ozkan
Copy link
Member

We should straight-up advise setting download-ci-llvm = false.

Alternatively, if they don't want to compile LLVM for some reason and prefer to use a precompiled version, there is a better way. They can specify the path to llvm-config like this:

[target.x86_64-unknown-linux-gnu]
llvm-config = "/path/to/llvm-config"

Maybe we should include this in the error message.

@bjorn3
Copy link
Member

bjorn3 commented May 31, 2025

We should straight-up advise setting download-ci-llvm = false.

We could also forcefully set download-ci-llvm to false if the current channel is not dev or nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants