terminology: allocated object → allocation #141224

RalfJung · 2025-05-18T12:44:51Z

Rust does not have "objects" in memory so "allocated object" is a somewhat odd name. I am not sure where the term comes from. "object" has been used to refer to allocations already in 1.0 docs; this was apparently later changed to "allocated object".

"Allocation" is already the terminology used in Miri and in the UCG. We should properly move to that terminology, and avoid any confusion about whether Rust has an object memory model. (It does not. Memory contains untyped bytes.)

Cc @rust-lang/opsem @rust-lang/lang

rustbot · 2025-05-18T12:44:56Z

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-05-18T12:44:57Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

RalfJung · 2025-05-18T12:46:20Z

library/core/src/ptr/mod.rs

@@ -95,24 +95,24 @@
 //!
 //! [valid value]: ../../reference/behavior-considered-undefined.html#invalid-values
 //!
-//! ## Allocated object
+//! ## Allocation


This will break existing links to #allocated-object. Dos anyone have an idea how we could avoid that?

Inline html? Something like:

<a id="allocated-object"></a>

This will break existing links to #allocated-object. Does anyone have an idea how we could avoid that?

Here's what we do in the Reference.

Yeah... but not sure if I can just put that in a doc comment.

traviscross · 2025-05-18T13:55:37Z

Agreed.

@rfcbot fcp merge

rfcbot · 2025-05-18T13:55:38Z

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

tmandry · 2025-05-21T15:21:15Z

@rfcbot reviewed

rfcbot · 2025-05-21T15:21:23Z

🔔 This is now entering its final comment period, as per the review above. 🔔

scottmcm · 2025-05-21T15:39:50Z

I could have sworn it came from C++, but looking again I can't see any evidence of that.

So I guess it's from https://llvm.org/docs/LangRef.html#allocated-objects:

An allocated object, memory object, or simply object, is a region of a memory space that is reserved by a memory allocation such as alloca, heap allocation calls, and global variable definitions.

Co-Authored-By: RalfJung <post@ralfj.de>

This reverts commit aa975c6. "Allocations" in line 116 in library/core/src/ptr/mod.rs was kept, however, because it was added as part of this commit series in rust-lang@5a52202#diff-c175d4e27676febf62c061d31cf9756d256b46e2e44cc6b3177d4ff75e932567R116-R118

bors · 2025-05-31T02:23:44Z

☔ The latest upstream changes (presumably #141791) made this pull request unmergeable. Please resolve the merge conflicts.

rfcbot · 2025-05-31T15:23:37Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

traviscross · 2025-05-31T17:36:07Z

library/core/src/ptr/mut_ptr.rs

+    /// `mid` must be [in-bounds] of the underlying [allocation].
    /// Which means `self` must be dereferenceable and span a single allocation
    /// that is at least `mid * size_of::<T>()` bytes long. Not upholding these
    /// requirements is *[undefined behavior]* even if the resulting pointers are not used.
    ///
    /// [in-bounds]: #method.add
    /// [out-of-bounds index]: #method.add
+    /// [allocation]: crate::ptr#allocation


Good catch that this was broken in the original.

traviscross · 2025-05-31T17:38:27Z

There are conflicts to resolve, then r=me.

@rustbot author

traviscross · 2025-05-31T22:57:37Z

Thanks @RalfJung.

@bors r+ rollup

bors · 2025-05-31T22:57:40Z

📌 Commit f388c98 has been approved by traviscross

It is now in the queue for this repository.

terminology: allocated object → allocation Rust does not have "objects" in memory so "allocated object" is a somewhat odd name. I am not sure where the term comes from. "object" has been used to refer to allocations already [in 1.0 docs](https://doc.rust-lang.org/1.0.0/std/primitive.pointer.html#method.offset); this was apparently later changed to "allocated object". "Allocation" is already the terminology used in Miri and in the [UCG](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#allocation). We should properly move to that terminology, and avoid any confusion about whether Rust has an object memory model. (It does not. Memory contains untyped bytes.) Cc `@rust-lang/opsem` `@rust-lang/lang`

Rollup of 9 pull requests Successful merges: - #140370 (Improve diagnostics for usage of qualified paths within tuple struct exprs/pats) - #141224 (terminology: allocated object → allocation) - #141622 (implement `va_arg` for `powerpc`) - #141666 (source_span_for_markdown_range: fix utf8 violation) - #141789 (Exclude `CARGO_HOME` from `generate-copyright` in-tree determination) - #141823 (Drive-by refactor: use `OnceCell` for the reverse region SCC graph) - #141834 (Add unimplemented `current_dll_path()` for WASI) - #141846 (Fix TLS model on bootstrap for cygwin) - #141852 (resolve if-let-chain FIXME on bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141224 - RalfJung:no-objects, r=traviscross terminology: allocated object → allocation Rust does not have "objects" in memory so "allocated object" is a somewhat odd name. I am not sure where the term comes from. "object" has been used to refer to allocations already [in 1.0 docs](https://doc.rust-lang.org/1.0.0/std/primitive.pointer.html#method.offset); this was apparently later changed to "allocated object". "Allocation" is already the terminology used in Miri and in the [UCG](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#allocation). We should properly move to that terminology, and avoid any confusion about whether Rust has an object memory model. (It does not. Memory contains untyped bytes.) Cc ``@rust-lang/opsem`` ``@rust-lang/lang``

Rollup of 9 pull requests Successful merges: - rust-lang/rust#140370 (Improve diagnostics for usage of qualified paths within tuple struct exprs/pats) - rust-lang/rust#141224 (terminology: allocated object → allocation) - rust-lang/rust#141622 (implement `va_arg` for `powerpc`) - rust-lang/rust#141666 (source_span_for_markdown_range: fix utf8 violation) - rust-lang/rust#141789 (Exclude `CARGO_HOME` from `generate-copyright` in-tree determination) - rust-lang/rust#141823 (Drive-by refactor: use `OnceCell` for the reverse region SCC graph) - rust-lang/rust#141834 (Add unimplemented `current_dll_path()` for WASI) - rust-lang/rust#141846 (Fix TLS model on bootstrap for cygwin) - rust-lang/rust#141852 (resolve if-let-chain FIXME on bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

terminology: allocated object → allocation Rust does not have "objects" in memory so "allocated object" is a somewhat odd name. I am not sure where the term comes from. "object" has been used to refer to allocations already [in 1.0 docs](https://doc.rust-lang.org/1.0.0/std/primitive.pointer.html#method.offset); this was apparently later changed to "allocated object". "Allocation" is already the terminology used in Miri and in the [UCG](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#allocation). We should properly move to that terminology, and avoid any confusion about whether Rust has an object memory model. (It does not. Memory contains untyped bytes.) Cc ``@rust-lang/opsem`` ``@rust-lang/lang``

…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#140370 (Improve diagnostics for usage of qualified paths within tuple struct exprs/pats) - rust-lang#141224 (terminology: allocated object → allocation) - rust-lang#141622 (implement `va_arg` for `powerpc`) - rust-lang#141666 (source_span_for_markdown_range: fix utf8 violation) - rust-lang#141789 (Exclude `CARGO_HOME` from `generate-copyright` in-tree determination) - rust-lang#141823 (Drive-by refactor: use `OnceCell` for the reverse region SCC graph) - rust-lang#141834 (Add unimplemented `current_dll_path()` for WASI) - rust-lang#141846 (Fix TLS model on bootstrap for cygwin) - rust-lang#141852 (resolve if-let-chain FIXME on bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jhpratt May 18, 2025

rustbot added S-waiting-on-review T-compiler T-libs labels May 18, 2025

RalfJung added the I-lang-nominated label May 18, 2025

RalfJung commented May 18, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

RalfJung force-pushed the no-objects branch from 0f38d79 to 67392a1 Compare May 18, 2025 13:21

RalfJung mentioned this pull request May 18, 2025

rustdoc does not detect broken markdown due to missing links (except for links without a space) #141227

Open

RalfJung force-pushed the no-objects branch from 67392a1 to e32c69a Compare May 18, 2025 13:34

traviscross added P-lang-drag-2 T-lang and removed T-compiler T-libs labels May 18, 2025

rfcbot added proposed-final-comment-period disposition-merge labels May 18, 2025

traviscross assigned traviscross and unassigned jhpratt May 18, 2025

traviscross added I-lang-easy-decision P-lang-drag-1 and removed P-lang-drag-2 labels May 21, 2025

rfcbot added final-comment-period and removed proposed-final-comment-period labels May 21, 2025

LuigiPiucco added a commit to LuigiPiucco/rust that referenced this pull request May 23, 2025

make changes compatible with rust-lang#141224

aa975c6

Co-Authored-By: RalfJung <post@ralfj.de>

rfcbot added finished-final-comment-period to-announce and removed final-comment-period labels May 31, 2025

rustbot mentioned this pull request May 31, 2025

Tracking issue for release notes of #141224: terminology: allocated object → allocation #141820

Closed

traviscross reviewed May 31, 2025

View reviewed changes

rustbot added S-waiting-on-author and removed S-waiting-on-review labels May 31, 2025

terminology: allocated object → allocation

f388c98

RalfJung force-pushed the no-objects branch from e32c69a to f388c98 Compare May 31, 2025 20:49

bors added S-waiting-on-bors and removed S-waiting-on-author labels May 31, 2025

This was referenced Jun 1, 2025

Rollup of 9 pull requests #141868

Closed

Rollup of 9 pull requests #141869

Merged

bors merged commit 335232d into rust-lang:master Jun 1, 2025
9 checks passed

rustbot added this to the 1.89.0 milestone Jun 1, 2025

RalfJung deleted the no-objects branch June 4, 2025 06:45

apiraino removed the to-announce label Jun 5, 2025

terminology: allocated object → allocation #141224

terminology: allocated object → allocation #141224

Uh oh!

Conversation

RalfJung commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 18, 2025

Uh oh!

rustbot commented May 18, 2025

Uh oh!

RalfJung May 18, 2025

Choose a reason for hiding this comment

Uh oh!

ChrisDenton May 18, 2025

Choose a reason for hiding this comment

Uh oh!

traviscross May 18, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung May 18, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

traviscross commented May 18, 2025

Uh oh!

rfcbot commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmandry commented May 21, 2025

Uh oh!

rfcbot commented May 21, 2025

Uh oh!

scottmcm commented May 21, 2025

Uh oh!

bors commented May 31, 2025

Uh oh!

rfcbot commented May 31, 2025

Uh oh!

traviscross May 31, 2025

Choose a reason for hiding this comment

Uh oh!

traviscross commented May 31, 2025

Uh oh!

traviscross commented May 31, 2025

Uh oh!

bors commented May 31, 2025

Uh oh!

Uh oh!

Uh oh!

RalfJung commented May 18, 2025 •

edited

Loading

rfcbot commented May 18, 2025 •

edited

Loading