Skip to content

[perf ONLY] [gauge upper bound] rustdoc: Remove auto trait impl synthesis #141564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmease
Copy link
Member

@fmease fmease commented May 25, 2025

No description provided.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 25, 2025
@fmease fmease added the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label May 25, 2025
@fmease
Copy link
Member Author

fmease commented May 25, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 25, 2025
bors added a commit that referenced this pull request May 25, 2025
[perf ONLY] [gauge upper bound] rustdoc: Remove auto trait synthesis
@bors
Copy link
Collaborator

bors commented May 25, 2025

⌛ Trying commit ac6ef53 with merge dcde543...

@fmease fmease added the rla-silenced Silences rust-log-analyzer postings to the PR it's added on. label May 25, 2025
@fmease fmease changed the title [perf ONLY] [gauge upper bound] rustdoc: Remove auto trait synthesis [perf ONLY] [gauge upper bound] rustdoc: Remove auto trait impl synthesis May 25, 2025
@fmease fmease added rla-silenced Silences rust-log-analyzer postings to the PR it's added on. and removed rla-silenced Silences rust-log-analyzer postings to the PR it's added on. labels May 26, 2025
@bors
Copy link
Collaborator

bors commented May 26, 2025

☀️ Try build successful - checks-actions
Build commit: dcde543 (dcde54343082b9adfbcb57d70169a7cdd94ba90d)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dcde543): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-8.2% [-25.5%, -0.8%] 17
Improvements ✅
(secondary)
-3.3% [-16.7%, -0.3%] 9
All ❌✅ (primary) -8.2% [-25.5%, -0.8%] 17

Max RSS (memory usage)

Results (primary -0.2%, secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
7.3% [2.1%, 11.2%] 3
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
-3.9% [-8.7%, -1.4%] 6
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.2% [-8.7%, 11.2%] 9

Cycles

Results (primary -8.2%, secondary -7.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-8.2% [-21.0%, -2.3%] 14
Improvements ✅
(secondary)
-7.0% [-15.1%, -2.4%] 3
All ❌✅ (primary) -8.2% [-21.0%, -2.3%] 14

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.708s -> 776.163s (0.06%)
Artifact size: 366.25 MiB -> 366.16 MiB (-0.03%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants