-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Reduce ast::ptr::P
to a typedef of Box
#141603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
These date back to 2014. I don't think they're needed any more.
It's barely used, and the places that use it are better if they don't.
A `Vec` is fine, the additional word (vector vs. boxed slice) doesn't matter here.
It's no longer used.
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Reduce `ast::ptr::P` to a typedef of `Box` r? `@ghost`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (968f45f): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 1.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -1.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 778.13s -> 778.268s (0.02%) |
Perf effect is somewhere between neutral and slightly improved. |
Keep the `P` constructor function for now, to minimize immediate churn. All the `into_inner` calls are removed, which is nice.
If you need a reviewer for after the MCP passes, I can help |
Waiting on approval for rust-lang/compiler-team#878. |
Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
The MCP has been approved, this is ready to proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// FIXME: Use an 'if let' guard once they are implemented | ||
if let ast::StmtKind::Item(i) = stmt.into_inner().kind { | ||
(i, true) | ||
} else { | ||
unreachable!() | ||
} | ||
if let ast::StmtKind::Item(i) = stmt.kind { (i, true) } else { unreachable!() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be fixed. I'll do so in a followup.
if matches!(inner_pat.clone().kind, PatKind::Ident(..)) => | ||
{ | ||
match inner_pat.clone().into_inner().kind { | ||
match inner_pat.clone().kind { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also
@bors r+ rollup |
As per the MCP at rust-lang/compiler-team#878.
r? @fee1-dead