-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Document what distcheck
is intended to exercise
#141646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like this doesn't currently try to exercise |
diskcheck
is intended to exercisedistcheck
is intended to exercise
Note there is a typo in the commit message ( |
https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chkdsk 😁 |
(Fixed, thanks) |
@bors r+ This seems broadly true to me -- the real 'intent' here is to ensure that the distributed tarballs are actually useful for intended purposes. We do a partial job of that with the steps here today :) |
Rollup of 8 pull requests Successful merges: - #140787 (Note expr being cast when encounter NonScalar cast error) - #141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods) - #141646 (Document what `distcheck` is intended to exercise) - #141740 (Hir item kind field order) - #141793 (`tests/ui`: A New Order [1/N]) - #141805 (Update `compiler-builtins` to 0.1.160) - #141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows) - #141819 (Fixes for building windows-gnullvm hosts) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #141646 - jieyouxu:distcheck, r=Mark-Simulacrum Document what `distcheck` is intended to exercise Or at least attempt to. Closes #141387. cc `@marcoieni` (re. [#t-infra/bootstrap > Speed up distcheck](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Speed.20up.20distcheck/with/520208870)) r? `@Mark-Simulacrum` (as you may have some clues about if this is accurate)
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#140787 (Note expr being cast when encounter NonScalar cast error) - rust-lang#141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods) - rust-lang#141646 (Document what `distcheck` is intended to exercise) - rust-lang#141740 (Hir item kind field order) - rust-lang#141793 (`tests/ui`: A New Order [1/N]) - rust-lang#141805 (Update `compiler-builtins` to 0.1.160) - rust-lang#141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows) - rust-lang#141819 (Fixes for building windows-gnullvm hosts) r? `@ghost` `@rustbot` modify labels: rollup
Or at least attempt to.
Closes #141387.
cc @marcoieni (re. #t-infra/bootstrap > Speed up distcheck)
r? @Mark-Simulacrum (as you may have some clues about if this is accurate)