Skip to content

Document what distcheck is intended to exercise #141646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented May 27, 2025

Or at least attempt to.

Closes #141387.

cc @marcoieni (re. #t-infra/bootstrap > Speed up distcheck)
r? @Mark-Simulacrum (as you may have some clues about if this is accurate)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 27, 2025
@jieyouxu
Copy link
Member Author

Looks like this doesn't currently try to exercise rustc-dev dist component at all, I wonder if we could catch potential breakages to rustc-dev like #141595 next doors without having to... guess 😅

@ehuss ehuss changed the title Document what diskcheck is intended to exercise Document what distcheck is intended to exercise May 27, 2025
@ehuss
Copy link
Contributor

ehuss commented May 27, 2025

Note there is a typo in the commit message (diskcheck -> distcheck)

@jieyouxu
Copy link
Member Author

jieyouxu commented May 27, 2025

Note there is a typo in the commit message (diskcheck -> distcheck)

https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chkdsk 😁

@jieyouxu
Copy link
Member Author

(Fixed, thanks)

@Mark-Simulacrum
Copy link
Member

@bors r+

This seems broadly true to me -- the real 'intent' here is to ensure that the distributed tarballs are actually useful for intended purposes. We do a partial job of that with the steps here today :)

@bors
Copy link
Collaborator

bors commented May 31, 2025

📌 Commit d43c2e7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2025
bors added a commit that referenced this pull request May 31, 2025
Rollup of 8 pull requests

Successful merges:

 - #140787 (Note expr being cast when encounter NonScalar cast error)
 - #141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods)
 - #141646 (Document what `distcheck` is intended to exercise)
 - #141740 (Hir item kind field order)
 - #141793 (`tests/ui`: A New Order [1/N])
 - #141805 (Update `compiler-builtins` to 0.1.160)
 - #141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows)
 - #141819 (Fixes for building windows-gnullvm hosts)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ec39208 into rust-lang:master May 31, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 31, 2025
rust-timer added a commit that referenced this pull request May 31, 2025
Rollup merge of #141646 - jieyouxu:distcheck, r=Mark-Simulacrum

Document what `distcheck` is intended to exercise

Or at least attempt to.

Closes #141387.

cc `@marcoieni` (re. [#t-infra/bootstrap > Speed up distcheck](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Speed.20up.20distcheck/with/520208870))
r? `@Mark-Simulacrum` (as you may have some clues about if this is accurate)
@jieyouxu jieyouxu deleted the distcheck branch June 3, 2025 03:57
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 3, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#140787 (Note expr being cast when encounter NonScalar cast error)
 - rust-lang#141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods)
 - rust-lang#141646 (Document what `distcheck` is intended to exercise)
 - rust-lang#141740 (Hir item kind field order)
 - rust-lang#141793 (`tests/ui`: A New Order [1/N])
 - rust-lang#141805 (Update `compiler-builtins` to 0.1.160)
 - rust-lang#141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows)
 - rust-lang#141819 (Fixes for building windows-gnullvm hosts)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document intention of the distcheck bootstrap step/command, and the distcheck CI test job
5 participants