Skip to content

rustdoc: fix attrs of locally reexported foreign items #141831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

rustdoc: fix attrs of locally reexported foreign items #141831

wants to merge 3 commits into from

Conversation

lolbinarycat
Copy link
Contributor

@lolbinarycat lolbinarycat commented May 31, 2025 •
edited by rustbot
Loading

fixes #135092

also tweaks a few outdated/misleading comments.

r? @GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels May 31, 2025
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the rustdoc-extern-reexport-135092 branch from 3ea7aa7 to 6494a7d Compare June 2, 2025 21:43
@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the rustdoc-extern-reexport-135092 branch from 6494a7d to b400cfa Compare June 2, 2025 23:16
aDotInTheVoid
aDotInTheVoid reviewed Jun 3, 2025
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aDotInTheVoid aDotInTheVoid

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rustdoc does not combine documentation in re-exports of extern functions
5 participants
@lolbinarycat @rustbot @rust-log-analyzer @aDotInTheVoid @GuillaumeGomez