Skip to content

Fix broken link to rustc_type_ir module in serialization docs #141870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidjsonn
Copy link
Contributor

PR fixes a broken link in the Rust compiler documentation. The original link pointed to rustc_type_ir/codec.rs, which no longer exists in the current compiler architecture. This functionality has been moved to the rustc_middle crate.

The change updates the broken link:

@rustbot
Copy link
Collaborator

rustbot commented Jun 1, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 1, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

@fee1-dead
Copy link
Member

r=me and errs once the suggestion is applied.

@fee1-dead fee1-dead added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025
@davidjsonn
Copy link
Contributor Author

What would you suggest doing?

@fee1-dead
Copy link
Member

errs gave a suggestion in his review

Co-authored-by: Michael Goulet <michael@errs.io>
@davidjsonn
Copy link
Contributor Author

done, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants