Subtree update of `rust-analyzer` #142250

lnicola · 2025-06-09T16:45:45Z

Co-authored-by: Lukas Wirth <me@lukaswirth.dev>

…word and on visibility

Produce ClosureBinder node in atom.rs

The Rust source code previously mised ProjectJson and JsonProject, and the TypeScript definition didn't match either. Use 'ProjectJson' everywhere. This is purely an internal change.

internal: Use 'ProjectJson' consistently

…riginal symbol Co-authored-by: Jake Goulding <jake.goulding@integer32.com>

Enhance renaming to include identifiers that are generated from the original symbol

…nostics

Enable Assist edit for tuple<->named struct for the struct and visiblity keywords

fix: Cycle handlers for `HirDatabase::infer, const_param_ty_with_diagnostics`

Add a quickfix for accessing a private field of a struct

Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.2 to 2.1.3. - [Commits](https://github.com/mafintosh/tar-fs/commits) --- updated-dependencies: - dependency-name: tar-fs dependency-version: 2.1.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

ci: Pin `cargo-workspaces` to `0.3.6`

Revert `cargo-workspaces` version fix

ci: When autopublishing, remove `xtask` from workspace

fix: Record macro calls in signatures in `ChildBySource` impls

Better parser recovery for macro calls in type bound position

…disabled

…-stable fix: Stabilize unlinked file diagnostic

…-quickfix fix: Always include quickfixes for diagnostics, even when diagnostics are disabled

fix: Record macro calls for fields in `ChildBySource` impls

…attribute_completions feat: implement attribute completions for diagnostics module

fix: Stabilize the "JSON is not Rust" diagnostic

minor: Sync from downstream

rustbot · 2025-06-09T16:45:50Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2025-06-09T17:11:54Z

@bors r+ p=1 subtree sync

bors · 2025-06-09T17:11:57Z

📌 Commit f5bfde2 has been approved by lnicola

It is now in the queue for this repository.

bors · 2025-06-10T01:52:21Z

⌛ Testing commit f5bfde2 with merge 8a407a8...

bors · 2025-06-10T04:55:18Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 8a407a8 to master...

github-actions · 2025-06-10T04:58:32Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c6768de (parent) -> 8a407a8 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8a407a82848bbc926de1cbbbbcb381e1a96f5968 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 5769.0s -> 7776.5s (34.8%)
x86_64-apple-2: 3710.7s -> 4636.1s (24.9%)
aarch64-apple: 4598.4s -> 3721.4s (-19.1%)
dist-apple-various: 9413.9s -> 7796.1s (-17.2%)
dist-x86_64-apple: 11889.8s -> 10255.2s (-13.7%)
dist-ohos-x86_64: 4573.3s -> 4045.0s (-11.6%)
dist-aarch64-apple: 5423.1s -> 4854.2s (-10.5%)
dist-ohos-armv7: 4338.5s -> 3899.9s (-10.1%)
dist-s390x-linux: 5197.4s -> 4710.4s (-9.4%)
dist-powerpc64le-linux-gnu: 5377.7s -> 4886.7s (-9.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-10T09:16:11Z

Finished benchmarking commit (8a407a8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.17s -> 753.608s (-0.21%)
Artifact size: 372.30 MiB -> 372.36 MiB (0.02%)

aibaars and others added 30 commits May 30, 2025 22:38

Produce ClosureBinder node in atom.rs

47d9534

Add test for closure_binder

d3a7d1c

Co-authored-by: Lukas Wirth <me@lukaswirth.dev>

Run 'cargo codegen' to update tests

bd71e6c

Update expected test output

ca48112

Allow assist edit for converting structs to appear also on struct key…

e3d26cd

…word and on visibility

add missing public keyword

a241d8e

Formatting issues resolved

01837bc

rename function so it makes more sense

b34e36b

clippy and more formatting

4f018d8

Merge pull request rust-lang#19897 from aibaars/patch-2

6a44c01

Produce ClosureBinder node in atom.rs

internal: Use 'ProjectJson' consistently

d964f5d

The Rust source code previously mised ProjectJson and JsonProject, and the TypeScript definition didn't match either. Use 'ProjectJson' everywhere. This is purely an internal change.

Merge pull request rust-lang#19904 from Wilfred/project_json_naming

1099b63

internal: Use 'ProjectJson' consistently

Enhance renaming to include identifiers that are generated from the o…

4d7b1a4

…riginal symbol Co-authored-by: Jake Goulding <jake.goulding@integer32.com>

fix: Fix edition handling for names in rename logic

4c1f3c6

Support derive-macros for rename prefix magic

a18f232

Merge pull request rust-lang#19893 from Veykril/push-wzqsompmnlmx

23f79c1

Enhance renaming to include identifiers that are generated from the original symbol

fix: don't duplicate must_use for functions and traits

3f0df08

simplify expression that checks the offset

d122bd4

feat: implement completion for diagnostic module

59fe399

fix: Cycle handlers for `HirDatabase::infer, const_param_ty_with_diag…

ddcc1af

…nostics

Add a quickfix for accessing a private field of a struct

e323eae

Merge pull request rust-lang#19901 from BazookaMusic/master

ae8e361

Enable Assist edit for tuple<->named struct for the struct and visiblity keywords

Merge pull request rust-lang#19894 from ShoyuVanilla/some-query-cycles

e179d2b

fix: Cycle handlers for `HirDatabase::infer, const_param_ty_with_diagnostics`

Merge pull request rust-lang#19869 from MatrixFrog/publicize_field

2ada018

Add a quickfix for accessing a private field of a struct

ci: Pin cargo-workspaces to 0.3.6

840142b

hir-ty: add incremental tests checking for infer invalidation

32297bd

Merge pull request rust-lang#19915 from ShoyuVanilla/publish-libs-crash

e5fb11a

ci: Pin `cargo-workspaces` to `0.3.6`

ci: When autopublishing, remove xtask from workspace

cd38deb

Revert `cargo-workspaces` version fix

Merge pull request rust-lang#19919 from ShoyuVanilla/patch-1

8f5d007

ci: When autopublishing, remove `xtask` from workspace

Veykril and others added 16 commits June 5, 2025 15:04

fix: Record macro calls in signatures in ChildBySource impls

129d568

Merge pull request rust-lang#19932 from Veykril/push-skzlyntpxpsw

929f82a

fix: Record macro calls in signatures in `ChildBySource` impls

Better parser recovery for macro calls in type bound position

1de4972

Merge pull request rust-lang#19933 from Veykril/push-uyxorpyvnzsl

d2c0de2

Better parser recovery for macro calls in type bound position

Always include quickfixes for diagnostics, even when diagnostics are …

0713466

…disabled

Stabilize unlinked file diagnostic

903a0db

fix: Record macro calls for fields in ChildBySource impls

e90b3fb

Merge pull request rust-lang#19936 from ChayimFriedman2/unlinked-file…

c8b0b08

…-stable fix: Stabilize unlinked file diagnostic

Merge pull request rust-lang#19935 from ChayimFriedman2/exp-diag-show…

98a4508

…-quickfix fix: Always include quickfixes for diagnostics, even when diagnostics are disabled

Merge pull request rust-lang#19937 from Veykril/push-rvnylnlnxxyr

337c2d9

fix: Record macro calls for fields in `ChildBySource` impls

Merge pull request rust-lang#19908 from rmehri01/rmehri01/diagnostic_…

3bae562

…attribute_completions feat: implement attribute completions for diagnostics module

Stabilize the "JSON is not Rust" diagnostic

814b9a1

Merge pull request rust-lang#19949 from ChayimFriedman2/stabilize-json

37c8788

fix: Stabilize the "JSON is not Rust" diagnostic

Preparing for merge from rust-lang/rust

cbe6fe8

Merge from rust-lang/rust

88223c5

Merge pull request rust-lang#19954 from lnicola/sync-from-rust

f5bfde2

minor: Sync from downstream

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 10, 2025

bors merged commit 8a407a8 into rust-lang:master Jun 10, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 10, 2025

lnicola deleted the sync-from-ra branch June 10, 2025 08:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Subtree update of `rust-analyzer` #142250

Subtree update of `rust-analyzer` #142250

Uh oh!

lnicola commented Jun 9, 2025

Uh oh!

rustbot commented Jun 9, 2025

Uh oh!

lnicola commented Jun 9, 2025

Uh oh!

bors commented Jun 9, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

rust-timer commented Jun 10, 2025

Uh oh!

Uh oh!

Subtree update of rust-analyzer #142250

Subtree update of rust-analyzer #142250

Uh oh!

Conversation

lnicola commented Jun 9, 2025

Uh oh!

rustbot commented Jun 9, 2025

Uh oh!

lnicola commented Jun 9, 2025

Uh oh!

bors commented Jun 9, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 10, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

Subtree update of `rust-analyzer` #142250

Subtree update of `rust-analyzer` #142250