Show the offset, length and memory of uninit read errors #142673
+487
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
oli-obk
commented
Jun 18, 2025
Comment on lines
-666
to
+674
| throw_ub!(InvalidUninitBytes(None)); | ||
| throw_ub!(InvalidUninitBytes(match op.to_op(self)?.as_mplace_or_imm() { | ||
| Left(mplace) => mplace.ptr().provenance.and_then(|prov| { | ||
| let start = mplace.ptr().into_parts().1; | ||
| let size = op.layout().size; | ||
| let range = alloc_range(start, size); | ||
| Some((prov.get_alloc_id()?, BadBytesAccess { access: range, bad: range })) | ||
| }), | ||
| Right(_) => None, | ||
| })) |
There was a problem hiding this comment.
This one doesn't show up in diagnostics, but it seemed good to change it, too
This comment has been minimized.
This comment has been minimized.
|
grml. I haven't been able to run miri's dep tests in-tree in forever. Always sth about libc not found. Will try to bless the others and hope none of these need blessing |
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung
I want to improve memory dumps in general. Not sure yet how to do so best within rust diagnostics, but in a perfect world I could generate a dummy in-memory file (that contains the rendered memory dump) that we then can then provide regular rustc
Spans to. So we'd basically report normal diagnostics for them with squiggly lines and everything.