Migrate to hatchling. #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 5 5
Lines 344 344
Branches 69 69
=======================================
Hits 337 337
Misses 4 4
Partials 3 3 🚀 New features to boost your workflow:
|
Gallaecio
reviewed
Jun 13, 2025
src/protego/__init__.py
Outdated
| from ._ruleset import RequestRate, VisitTime | ||
|
|
||
| __all__ = ["Protego", "RequestRate", "VisitTime"] | ||
| __version__ = "0.4.0" |
There was a problem hiding this comment.
I thought this was no longer recommended, but I am not so sure anymore, so +0
There was a problem hiding this comment.
That's mostly about keeping and doesn't convince me that we want to add it, I just assumed it's best practices when I added it. So it looks like the simplest recommended way to specify the version is just version = in pyporoject.toml.
Gallaecio
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.