Skip to content

Update numpy array comparisons to use isin #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update numpy array comparisons to use isin #3685

wants to merge 2 commits into from

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary

This small PR resolves the NumPy deprecation warnings of np.in1d which you can find in the CI logs:

/home/runner/work/scanpy/scanpy/tests/test_ingest.py:87: DeprecationWarning: `in1d` is deprecated. Use `np.isin` instead.

@emmanuel-ferdman
Update numpy array comparisons to use isin
7c20e03 
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@flying-sheep flying-sheep added this to the 1.11.3 milestone Jun 17, 2025
@flying-sheep
Copy link
Member

flying-sheep commented Jun 17, 2025 •
edited
Loading

Thanks! Can you run

hatch run towncrier:create 3685.bugfix.md

then write a short description that ends with {smaller}`E Ferdman` , and push the file?

@emmanuel-ferdman
Update numpy array comparisons to use isin
51f976c 
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman
Copy link
Contributor Author

@flying-sheep sure, done. thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuel-ferdman @flying-sheep