-
-
Notifications
You must be signed in to change notification settings - Fork 357
Feature/add tree view #3585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/add tree view #3585
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks @dev-viinz, FYI you may see some portions of the CI checks fail right now. This is a known issue and I'm in progress on resolving this. I just ran out of time for today, so I'll resolve this and provide an initial review of your draft PR here tomorrow. Totally understand if things are a work in progress, so I won't nitpick I promise! Just want to ensure we have a firm foundation established. Again I'm out for a bit, but I'll try to check in later today if you respond on here or Discord. |
@dev-viinz see my comments in the Contributor section on Discord. Additionally, I ask that you please catch up your feature branch to the latest changes on Note that if you still see errors after merging the |
@endigo9740 It seems like the CI tasks that are not Vercel related need an approval after every push, is this intentional? |
@dev-viinz you can see GitHub's docs about this here.
We're just using the default configuration, which is a bit more locked down. We don't get so many contributions that it would likely cause a major issue, but that's the reasoning for it. The list of checks run can be replicated locally using the commands in the Checklist section in the original post above. I'd recommend you run through periodically during development to ensure all is well. I will verify everything is green when I do my full review though. I'll approve this again so you can see the current status. |
Linked Issue
Closes #3468
Description
Implements the Zag.js TreeView.
In this draft I'm starting with the svelte component until it's finalized, to then "port" it over to react.
Current Progress:
Checklist
Please read and apply all contribution requirements.
docs/
,feature/
,chore/
,bugfix/
main
branchpnpm check
in the root of the monorepopnpm format
in the root of the monorepopnpm lint
in the root of the monorepopnpm test
in the root of the monorepo/package
projects, please supply a ChangesetChangsets
View our documentation to learn more about Changesets. To create a Changeset:
pnpm changeset
and follow the prompts