Skip to content

Feature/add tree view #3585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

dev-viinz
Copy link

Linked Issue

Closes #3468

Description

Implements the Zag.js TreeView.
In this draft I'm starting with the svelte component until it's finalized, to then "port" it over to react.
Current Progress:

  • Add svelte component
  • Svelte component done
  • Add react component
  • React component done
  • Add changeset

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, chore/, bugfix/
  • Contributions should target the main branch
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changsets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR ready for review.

Copy link

changeset-bot bot commented Jul 1, 2025

⚠️ No Changeset found

Latest commit: dab9c6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www.skeleton.dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 6:06pm

@endigo9740
Copy link
Contributor

Thanks @dev-viinz, FYI you may see some portions of the CI checks fail right now. This is a known issue and I'm in progress on resolving this. I just ran out of time for today, so I'll resolve this and provide an initial review of your draft PR here tomorrow. Totally understand if things are a work in progress, so I won't nitpick I promise! Just want to ensure we have a firm foundation established.

Again I'm out for a bit, but I'll try to check in later today if you respond on here or Discord.

@endigo9740
Copy link
Contributor

endigo9740 commented Jul 3, 2025

@dev-viinz see my comments in the Contributor section on Discord. Additionally, I ask that you please catch up your feature branch to the latest changes on main. This includes fixes that will enable the full CI/CD check process to run successfully. I'll run the process now so you'll see the failure, then once updated this should be all green.

Note that if you still see errors after merging the main branch, those will likely be on your end to resolve. You should be able to run pnpm check in the root of the monorepo project to see these, otherwise let me know and I can help diagnose what's up.

@dev-viinz
Copy link
Author

@endigo9740 It seems like the CI tasks that are not Vercel related need an approval after every push, is this intentional?

@endigo9740
Copy link
Contributor

endigo9740 commented Jul 4, 2025

@dev-viinz you can see GitHub's docs about this here.

These workflow approval policies are intended to restrict the set of users that can execute workflows in GitHub Actions runners that could lead to unexpected resource and compute consumption when using GitHub-hosted runners.

We're just using the default configuration, which is a bit more locked down. We don't get so many contributions that it would likely cause a major issue, but that's the reasoning for it.

The list of checks run can be replicated locally using the commands in the Checklist section in the original post above. I'd recommend you run through periodically during development to ensure all is well. I will verify everything is green when I do my full review though.

I'll approve this again so you can see the current status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tree View Component
2 participants