Barrier waits in order of completion/failure. #384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
barrier-wait-order
branch
3 times, most recently
from
4028a19 to
c1546bd
Compare
ioquatix
force-pushed
the
barrier-wait-order
branch
from
c1546bd to
92de931
Compare
samuel-williams-shopify
force-pushed
the
barrier-wait-order
branch
from
5bc9867 to
4cbe228
Compare
|
This was merged in 9e11aef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be confusing that a barrier waits on tasks in order rather than in the order of completion/failure, especially if a single failure implies the complete failure of the operation. This change ensures
Barrier#waitreturns tasks in order of completion.Types of Changes
Contribution