Fix route_check.py to ignore local p2p IP prefixes #3882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
227374e to
da49c12
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
da49c12 to
44dcf95
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
44dcf95 to
c03c087
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
70f909b to
5930d70
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
5930d70 to
50e9636
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
50e9636 to
c605f09
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
c605f09 to
3ab0820
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
ac95347 to
d71aa3d
Compare
prabhataravind
force-pushed
the
paravind/route_check
branch
from
ef9d4bc to
84294b9
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
84294b9 to
44d3417
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
force-pushed
the
paravind/route_check
branch
from
44d3417 to
016c07e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* In some cases where there are repeated link flaps, route_check.py flags local
p2p IP prefixes as missing in APPL_DB. These /31 IPv4 or /126 IPv6 IPs are
not expected to be present in APPL_DB after a link goes down. This change
tries to filter out such entries.
Failure results: {{
"missed_ROUTE_TABLE_routes": [
"10.10.196.16/31",
"2603:10b0:31f:753::24/126"
]
}}
Failed. Look at reported mismatches above
add: []
del: [
"10.10.196.16/31",
"2603:10b0:31f:753::24/126"
]
Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
prabhataravind
force-pushed
the
paravind/route_check
branch
from
016c07e to
1b3425d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@prabhataravind , changes lgtm. Since loopback is /32, i think we are good in covering loopback ip. |
prsunny
previously approved these changes
Jul 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates route_check.py to ignore local point-to-point IP prefixes (/31 IPv4 and /126 IPv6) when checking for missing routes, and adds a corresponding test case.
- Introduce
is_point_to_point_prefix,get_local_p2p_ips, andfilter_out_local_p2p_ipshelpers. - Apply filtering in
check_routes_for_namespacebefore reporting missing APPL_DB routes. - Add test scenario (case 28) covering local P2P IP prefixes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/route_check_test_data.py | Add test case 28 for validating filtering of local p2p IPs. |
| scripts/route_check.py | New helpers to detect and exclude /31 (IPv4) and /126 (IPv6) prefixes. |
Comments suppressed due to low confidence (3)
scripts/route_check.py:450
- The
:returndescription is incorrect foris_point_to_point_prefix(it returns a boolean, not a list). Update the docstring to reflect that it returns True/False.
:return sorted list of local p2p IP prefixes
scripts/route_check.py:485
- [nitpick] Pretty-printing with
indent=4on every debug log may be expensive; consider logging a summary or cachingget_local_p2p_ipsresults to reduce repeated DB lookups and JSON serialization.
print_message(syslog.LOG_DEBUG, json.dumps({"APPL_DB_INTF": sorted(intf)}, indent=4))
tests/route_check_test_data.py:1321
- The IPv6 prefix here starts with '9603:...' but elsewhere (and in descriptions) it uses '2603:...'. This mismatch may cause the test to not cover the intended prefix.
"PortChannel1021:9603:10b0:503:df4::5e/126": {},
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Jul 15, 2025
qiluo-msft
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases where there are repeated link flaps, route_check.py flags local p2p IP prefixes as missing in APPL_DB. These /31 IPv4 or /126 IPv6 IPs are not expected to be present in APPL_DB after a link goes down. This change tries to filter out such entries.
Failure results: {{
"missed_ROUTE_TABLE_routes": [
"10.10.196.16/31",
"2603:10b0:31f:753::24/126"
]
}}
Failed. Look at reported mismatches above
add: []
del: [
"10.10.196.16/31",
"2603:10b0:31f:753::24/126"
]
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)