Use trunk check to manage static analysis / security / secret scans in svix #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab at migration to trunk check for svix.
Motivation
trunk checkis designed to manage all your static analysis / linting / formatting. Especially useful for polyglot repos like this one. Our local running daemon will also keep your clippy issues scanned in the background so you can push quickly your pull requests.Solution
Test out the solution locally / pull branch and then
curl https://get.trunk.io -fsSL | bash trunk checkNext steps would be to migrate to universal trunk check from Rust Lint action.