Add locale_is_right_to_left polyfill #527
Open
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/locale_is_right_to_lef
branch
from
30b4e10 to
beacebd
Compare
stof
reviewed
May 26, 2025
| @@ -33,4 +34,8 @@ public static function get_exception_handler(): ?callable | |||
|
|
|||
| return $handler; | |||
| } | |||
|
|
|||
| public static function locale_is_right_to_left(string $locale): bool { | |||
| return (bool) preg_match('/^(?:ar|he|fa|ur|ps|sd|ug|ckb|yi|dv|ku_arab|ku-arab)(?:[_-].*)?$/i', $locale); | |||
There was a problem hiding this comment.
I don't think this is the right implementation. What is right to left is a script, not a language. And locales might specify a script explicitly which is not the most likely script.
There was a problem hiding this comment.
I see, any suggestions? Sadly the original code does not help here: unicode-org/icu@53dcbe6
- A script is right-to-left according to the CLDR script metadata
- which corresponds to whether the script's letters have Bidi_Class=R or AL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://php.watch/versions/8.5/locale_is_right_to_left-Locale-isRightToleft