Fix for code scanning alert no. 1719: Client-side cross-site scripting #19607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/umbraco/Umbraco-CMS/security/code-scanning/1719
To fix the issue, we need to sanitize or encode the
window.location.href
value before including it in thehtml
string. The best approach is to use a library likeDOMPurify
to sanitize the value or encode it using a utility function to ensure it is safe for inclusion in HTML. This will prevent any malicious scripts from being executed.Steps to fix:
DOMPurify
or use a built-in encoding function to sanitize or encode thewindow.location.href
value.window.location.href
in thehtml
string with its sanitized or encoded version.