Add support for encoding/decoding compressed EC keys #57
Conversation
| else -> null | ||
| format.name == "JWK" && !provider.isWebCrypto | ||
| -> "JWK key format" | ||
| format == EC.PublicKey.Format.RAW.Compressed && provider.isApple |
There was a problem hiding this comment.
could you please mention this in limitations of apple provider?
cryptography-providers/webcrypto/src/commonMain/kotlin/algorithms/WebCryptoEc.kt
Show resolved
Hide resolved
| val ecKey = checkError(EVP_PKEY_get1_EC_KEY(key)) | ||
| val ecGroup = checkError(EC_KEY_get0_group(ecKey)) | ||
| val ecPoint = checkError(EC_KEY_get0_public_key(ecKey)) |
There was a problem hiding this comment.
Those functions are deprecated in openssl:
- https://docs.openssl.org/3.1/man3/EC_KEY_new/#synopsis
- https://docs.openssl.org/3.1/man3/EVP_PKEY_set1_RSA/#synopsis
Could you please replace them?
Looks like we need to find a way to provide OPENSSL_API_COMPAT to cinterop to hide those declarations to avoid usage them in future
There was a problem hiding this comment.
FYI: I was able to enforce OPENSSL_NO_DEPRECATED in cinterop in eeea305 and now those declarations are not available.
This commit will be soon merged into main, so if you willing to proceed with changing those you can temporary cherry-pick it from whyoleg/dev branch
There was a problem hiding this comment.
Sorry for the late reply. I will check when free.
There was a problem hiding this comment.
No problem, take your time.
FYI: openssl changes mentioned are already in main, so you can just rebase.
FYI2: At the current moment, I plan to do a release in mid-June, so it would be really nice to include those changes in it, along with your other contribution of RIPEMD!
There was a problem hiding this comment.
I've replaced those deprecated methods.
cryptography-providers/jdk/src/jvmMain/kotlin/algorithms/JdkEc.kt
Outdated
Show resolved
Hide resolved
cryptography-providers/jdk/src/jvmMain/kotlin/algorithms/JdkEc.kt
Outdated
Show resolved
Hide resolved
cryptography-providers/jdk/src/jvmMain/kotlin/algorithms/JdkEc.kt
Outdated
Show resolved
Hide resolved
|
Hey @huskcasaca, are you still willing to finish the PR? It's fine if you have no time for it. Just ping me, and I will rebase and finalize PR in your branch and so your contribution will still be there :) |
|
Sorry, can give me another week? |
|
@huskcasaca, yeah, sure, the release is planned by the end of the June, so you have roughly two weeks, otherwise it will go into the next major (0.6.0) release (as it's an ABI change) |
Co-authored-by: Oleg Yukhnevich <whyoleg@gmail.com>
# Conflicts: # cryptography-providers/jdk/src/jvmMain/kotlin/algorithms/JdkEc.kt
|
Added support for CryptoKit |
| ) | ||
| throws -> SwiftEcdhPublicKey | ||
| { | ||
| guard #available(iOS 16.0, macOS 13.0, tvOS 16.0, watchOS 9.0, *) else { |
| * For compressed points, the y-coordinate is computed by solving the curve equation: | ||
| * y² = x³ + ax + b (mod p) | ||
| * | ||
| * References: |
2 participants
This PR add support for
CompressedandUncompressed(default) format underRAWEC Public Key.