Storing api root url from discovery process

[adalpari]

Description

This PR stores the API_ROOT_URL from the discovery process in advance of waiting for the sites fetch to get it.
This is done this way to be sure we are using the result from the RS discovery in cases where there is no access to the current XML-RPC endpoints.
In addition, some refactor has been done and now we are using SiteStore directly instead of some SQL calls.

Testing instructions

1. Log into a self-hosted site
2. Enable Application Password and follow the login process

• Verify it works as expected
• Open the DB -> SiteModel and verify the credential fields and the WP_API_REST_URL one are filled

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[Copilot]

Pull Request Overview

This PR refactors the way application password credentials are stored by switching from direct SQL persistence to using the Flux dispatcher and SiteStore, and ensures the API root URL from discovery is saved. It also updates related tests and refines error logging.

• Refactor persistence: replace SiteSqlUtils calls with SiteStore and a new DispatcherWrapper
• Save wpApiRestUrl from the discovery result when storing credentials
• Update tests to mock and verify against siteStore and DispatcherWrapper

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/test/java/org/wordpress/android/ui/accounts/login/ApplicationPasswordLoginHelperTest.kt	Tests updated to mock SiteStore and DispatcherWrapper instead of SiteSqlUtils
src/main/java/org/wordpress/android/ui/accounts/login/ApplicationPasswordLoginHelper.kt	Replaced persistence with dispatcher actions, added API root URL capture, and wrapped dispatcher
src/main/java/org/wordpress/android/ui/accounts/applicationpassword/ApplicationPasswordLoginViewModel.kt	Adjusted log statements to use exception messages instead of raw stack trace arrays

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22005-2e71c07
	Commit	2e71c07
	Direct Download	jetpack-prototype-build-pr22005-2e71c07.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22005-2e71c07
	Commit	2e71c07
	Direct Download	wordpress-prototype-build-pr22005-2e71c07.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

Attention: Patch coverage is 61.90476% with 24 lines in your changes missing coverage. Please review.

Project coverage is 39.02%. Comparing base (f393c90) to head (2e71c07).
Report is 1 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ava/org/wordpress/android/fluxc/store/SiteStore.kt	0.00%	11 Missing ⚠️
...i/accounts/login/ApplicationPasswordLoginHelper.kt	77.77%	4 Missing and 2 partials ⚠️
...roid/fluxc/network/xmlrpc/site/SiteXMLRPCClient.kt	20.00%	4 Missing ⚠️
...ationpassword/ApplicationPasswordLoginViewModel.kt	85.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #22005   +/-   ##
=======================================
  Coverage   39.02%   39.02%           
=======================================
  Files        2153     2153           
  Lines      101494   101494           
  Branches    15585    15585           
=======================================
  Hits        39613    39613           
  Misses      58384    58384           
  Partials     3497     3497           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nbradbury]

@adalpari When I follow the testing steps using the same Jurassic Ninja site I shared with you on Slack earlier, I first see a toast saying the credentials were stored and then see another saying there was an error saving credentials:

apppass.mp4

Checking the SiteModel table for this site, I see this:

[adalpari]

@nbradbury I think there might be a race condition. I've now changed the approach. Could you give it another try?

[nbradbury]

I think there might be a race condition. I've now changed the approach. Could you give it another try?

That seems to have fixed the problem 🎉 Unfortunately, this PR is failing CI now. I'll go ahead and approve it and you can merge once that's addressed.

[adalpari]

I think there might be a race condition. I've now changed the approach. Could you give it another try?

That seems to have fixed the problem 🎉 Unfortunately, this PR is failing CI now. I'll go ahead and approve it and you can merge once that's addressed.

Yes, I broke some tests, so I am fixing them right now. Thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud