Fix: expose std.math.ldexp as C ldexp in compiler-rt to address LLVM release-mode simplification #24006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok I close my Pull Request. The task of removing the entries in |
|
As mentioned on #24005, this needs to remove any duplicate C implementations in |
alexrp
reviewed
Jun 2, 2025
added 16 commits
June 3, 2025 20:48
|
Converting this to a draft for now - it needs a bit more testing before it's ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23358
Adds the ldexp family of functions to compiler_rt, proxying the implementation to std.math.ldexp. Inspired by the approach taken to exp2, which does not appear to handle errno when wrapping std.math.
A duplicate approach appeared as I was running the final tests:
#24005
I have regression tests which may be worth integrating if the above approach is preferred.