Skip to content

libc: Merge header directories for glibc and NetBSD libc where applicable #24025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented May 29, 2025

See:

Manual patches required:

  • lib/libc/include/csky-linux-gnu/gnu/{lib-names,stubs}.h
  • lib/libc/include/powerpc-linux-gnu/bits/long-double.h

These must be maintained (same as any other Zig header patch) on glibc header updates.

Takes lib/libc/include from 115.5 MB to 113.4 MB.

Closes #21258.

These are almost entirely identical, with these exceptions:

* lib/libc/include/csky-linux-{gnueabi,gnueabihf}
    * gnu/{lib-names,stubs}.h will need manual patching for float ABI.
* lib/libc/include/{powerpc-linux-{gnueabi,gnueabihf},{powerpc64,powerpc64le}-linux-gnu}
    * bits/long-double.h will need manual patching for long double ABI.
@alexrp alexrp requested a review from andrewrk May 29, 2025 21:45
alexrp added 2 commits May 30, 2025 00:15
…able.

Manual patches:

* lib/libc/include/csky-linux-gnu/gnu/{lib-names,stubs}.h
* lib/libc/include/powerpc-linux-gnu/bits/long-double.h

Takes lib/libc/include from 115.5 MB to 113.4 MB.

Closes ziglang#21258.
@alexrp alexrp force-pushed the glibc-deduplication branch from 7c6e06f to 63a9048 Compare May 29, 2025 22:15
@alexrp alexrp merged commit 3b2bef8 into ziglang:master Jun 4, 2025
9 checks passed
@alexrp alexrp deleted the glibc-deduplication branch June 4, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Size saving opportunity in glibc include directories
1 participant