Skip to content

deepl: update livecheck and legacy versions #216243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Conversation

brzzdev
Copy link
Contributor

@brzzdev brzzdev commented Jun 13, 2025

The existing implementation of DeepL used regex to search for the 'most recent' version, which could often result in finding incorrect pre-release versions. (See mangerlahn/Latest#447)

I've simplified this down to just using https://www.deepl.com/macos/download/DeepL.dmg which will always point to the latest release version, and I've removed the no longer supported legacy versions.


Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

@khipp
Copy link
Member

khipp commented Jun 13, 2025

It makes sense to update the livecheck to use the Sparkle feed. However, we should continue using the versioned URL, as it allows for the computation of checksums.

Instead of removing the legacy versions, we could use skip "Legacy version" in the livecheck block for macOS Catalina and older, as they no longer receive updates.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Jun 13, 2025
@krehel krehel added the awaiting user reply Issue needs response from a user. label Jun 13, 2025
@khipp khipp changed the title Simplify and fix DeepL deepl: update livecheck and legacy versions Jun 16, 2025
@khipp khipp removed the awaiting user reply Issue needs response from a user. label Jun 16, 2025
@brzzdev
Copy link
Contributor Author

brzzdev commented Jun 16, 2025

Keeping the livecheck makes sense but I'm not sure I agree on keeping all the legacy versions.

They used to be listed on deepl.com, but they've now been removed and no support for them is offered.

@khipp
Copy link
Member

khipp commented Jun 18, 2025

Keeping the livecheck makes sense but I'm not sure I agree on keeping all the legacy versions.

I don't see any downside to keeping the legacy versions unless they are known to have issues or make the cask harder to maintain. @bevanjkay, I would love your thoughts on this.

@reitermarkus
Copy link
Member

As long as the download URLs for the legacy versions work, I also don't see a reason for removing them.

@khipp khipp requested a review from bevanjkay June 22, 2025 08:52
@bevanjkay bevanjkay added this pull request to the merge queue Jun 23, 2025
Merged via the queue into Homebrew:master with commit d2be7e2 Jun 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants