Avoid nil point when config.Metrics is nil and expose all metrics if none are configured #4101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When metrics are configured on the controller, but no metrics are applied to the scale set, the listener would panic with nil dereference error.
This change applies all metrics by default if metrics are configured, but no customisation is being done.
To avoid server errors in the future, defaults are applied to the server address and the default endpoint. This code path should not be hit by default, since the
app.go
decides if it should apply metrics based on the server address. But it made sense to use the default:8080
port and/metrics
endpoint in the default function to future-proof the code.Fixes #3993