Add Config Options to Override github Host #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jk2K
reviewed
Jul 29, 2022
| @@ -71,6 +71,13 @@ inputs: | |||
| set-safe-directory: | |||
| description: Add repository path as safe.directory for Git global config by running `git config --global --add safe.directory <path>` | |||
| default: true | |||
|
|
|||
| setHost: | |||
| @@ -52,7 +52,7 @@ class GitAuthHelper { | |||
| this.settings = gitSourceSettings || (({} as unknown) as IGitSourceSettings) | |||
|
|
|||
| // Token auth header | |||
| const serverUrl = urlHelper.getServerUrl() | |||
| const serverUrl = urlHelper.getServerUrl(gitSourceSettings?.setHost) | |||
There was a problem hiding this comment.
change to
- const serverUrl = urlHelper.getServerUrl()
+ const serverUrl = urlHelper.getServerUrl(this.settings.setHost)| @@ -1,14 +1,15 @@ | |||
| import * as assert from 'assert' | |||
| import {IGitSourceSettings} from './git-source-settings' | |||
| import {URL} from 'url' | |||
| import { settings } from 'cluster' | |||
|
// Set safe.directory in git global config.
result.setSafeDirectory =
(core.getInput('set-safe-directory') || 'true').toUpperCase() === 'TRUE'
+ // set host
+ result.setHost = (core.getInput('set-host') || '')
+ return result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possible solution to #630 it certainly allows you to override between github instances, but would need some investigation to see if putting a non github host in would work properly.
All this does is simply add an optional input called
setHostthat will be returned instead of the github urls if defined.