Add GitHub Token Support and Refactor Code. #849
+159
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
out of curiosity, I also hit API Rate Limit issues when using |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for GitHub tokens to address API rate limits and refactors code for improved readability and maintainability.
- Introduces an optional token parameter to the GitHub HTTP headers helper.
- Refactors URL construction and error handling in the GraalVM installer.
- Updates associated tests with better grouping and improved mocking.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/util.ts | Added an optional token parameter to getGitHubHttpHeaders to support GitHub token usage. |
| src/distributions/graalvm/installer.ts | Refactored file URL construction, error handling, and platform logic for the GraalVM installer. |
| tests/distributors/graalvm-installer.test.ts | Improved test grouping, added helpers for mocking HTTP responses, and refined architecture mapping tests. |
Comments suppressed due to low confidence (1)
src/util.ts:186
- Consider updating the function's documentation or inline comments to clearly describe the new optional 'token' parameter and its behavior.
export function getGitHubHttpHeaders(token?: string): OutgoingHttpHeaders {
| packageType: 'jdk', | ||
| checkLatest: false | ||
| }); | ||
|
|
||
| const osType = distribution.getPlatform(); | ||
| if (osType === 'windows' && distroArch == 'aarch64') { | ||
| if (osType === 'windows' && distroArch === 'aarch64') { | ||
| return; // skip, aarch64 is not available for Windows |
There was a problem hiding this comment.
[nitpick] Instead of returning early inside the test body to skip the unsupported Windows aarch64 case, consider using a conditional test skip (e.g. test.skip for that iteration) to make the intent clearer.
Suggested change
| return; // skip, aarch64 is not available for Windows | |
| test.skip('Skipping test: aarch64 is not available for Windows'); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added GitHub Token Support to address API Rate Limit Issue for GraalVM and refactored the code to improve readability and maintainability.
Related issue:
Add link to the related issue.
Check list: