Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Conversation

@nayrangnu
Copy link

Added [] to the instantiation of a DistributionAggregation because it takes a list of buckets as a single argument. Current example fails.

Added `[]` to the instantiation of a DistributionAggregation because it takes a list of buckets as a single argument. Current example fails.
@nayrangnu nayrangnu requested review from a team, odeke-em and songy23 as code owners March 6, 2020 18:11
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Member

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the catch and welcome to the OpenCensus project!

@odeke-em
Copy link
Member

odeke-em commented Mar 6, 2020

Please sign the CLA and then when ready, please comment back here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants