Skip to content

[SERVER-2194] Add job for verifying the windows executor resource classes #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jan 3, 2023

Conversation

jbialy
Copy link
Contributor

@jbialy jbialy commented Dec 22, 2022

The purpose of this PR is to add support for testing the various resource classes available for the Windows execution environment. See ticket: SERVER-2194.

  • Update to config version 2.1 and refactor docker resource class config block to use reusable configuration.
  • Define docker and windows executors
  • Define verify_resource_class command for performing verification actions per specific executor.
  • Add executor_resource_class job which accepts executor_type and resource_class params.
  • Add CIRCLE_WINDOWS_EXECUTOR variable for checking if the windows workflows should be executed.
  • Update readme.

@jbialy jbialy self-assigned this Dec 22, 2022
@jbialy
Copy link
Contributor Author

jbialy commented Dec 22, 2022

PTE test with CIRCLE_WINDOWS_EXECUTOR=true:

CleanShot 2022-12-23 at 10 52 42@2x

PTE test with CIRCLE_WINDOWS_EXECUTOR not set:

CleanShot 2022-12-23 at 10 56 32@2x

@jbialy jbialy marked this pull request as ready for review December 23, 2022 15:13
@jbialy jbialy requested a review from a team December 23, 2022 15:13
@jbialy jbialy requested a review from gosuku January 3, 2023 14:50
@gosuku
Copy link

gosuku commented Jan 3, 2023

LGTM but for the comment that Atul made. Would be good to explicitly check for CIRCLE_WINDOWS_EXECUTOR==true

@jbialy jbialy requested a review from atulsingh0 January 3, 2023 18:59
@jbialy jbialy requested a review from circlery January 3, 2023 19:06
Copy link
Contributor

@circlery circlery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! LGTM!

@jbialy
Copy link
Contributor Author

jbialy commented Jan 3, 2023

I added a card to fixed the failed jobs on k9s -> https://circleci.atlassian.net/browse/SERVER-2233

@jbialy jbialy merged commit 4beb8fc into master Jan 3, 2023
@jbialy jbialy deleted the SERVER-2194-windows-resource-class branch January 3, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants