Skip to content

Contrib/testkube #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2025
Merged

Contrib/testkube #578

merged 2 commits into from
Jun 8, 2025

Conversation

jvcdk
Copy link
Contributor

@jvcdk jvcdk commented May 26, 2025

PR Checklist

@gecube
Copy link
Collaborator

gecube commented Jun 2, 2025

@jvcdk
Copy link
Contributor Author

jvcdk commented Jun 2, 2025

No; as the description says: I used the CRD Extractor tool to generate these CRDs (from a local running cluster).

Would you prefer a copy from your link? I don't know if they are different....

@gecube
Copy link
Collaborator

gecube commented Jun 3, 2025

@jvcdk Hi! I am not a maintainer of this project, so I could not give you positive or negative answer. What I can say - that I saw in the comments to PR to provide the links to the original repo from where the CRDs came. Even if you install them with helm or any other way, there would be a "golden source" some where in the sources of operator/ helm chart or something else.

@eyarz
Copy link
Member

eyarz commented Jun 6, 2025

Let me clarify the reason I'm asking for the CRD source 😊
It's mainly to confirm that the file path pattern is correct and to ensure we're not unintentionally adding auto-generated or irrelevant schemas to the repo — which can sometimes happen with the CRD extractor script.

Thanks you both for the help!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this submitted intentionally, or was it an accidental submission?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intentional. Seeing that the automatic update of the index.yaml was not yet in place, thought I would take the chance to make it up-to-date (at least to the content of my PR).

@eyarz eyarz merged commit 33adf25 into datreeio:main Jun 8, 2025
@eyarz eyarz mentioned this pull request Jun 8, 2025
@jvcdk jvcdk deleted the contrib/testkube branch June 9, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants