Add BUILDKIT_SYNTAX option handling #3157
Conversation
This fix allows building with a remote builder where frontend.dockerfile.v0 enabled = false in the buildkitd yaml file. Note that this change only allows the usage of BUILDKIT_SYNTAX with a custom frontend image, and using the #syntax directive in this case will still fail. Resolves: docker#3077 Signed-off-by: Will Nonnemaker <wnonnemaker@gmail.com>
|
This is my first pull request on this project, so any tips/guidance is much appreciated. I didn't write any unit tests for this feature, so if you want me to do that, let me know. The only way I tested this feature is by reproducing and fixing the bug locally, which I understand isn't best practice. While looking into this, I noticed a related bug where using the #syntax directive in a dockerfile will not be properly recognized if the BuildKit instance has |
There was a problem hiding this comment.
Look at the forwardGateway in https://github.com/moby/buildkit/blob/master/frontend/dockerfile/builder/build.go#L55-L56 . There is another parameter cmdline as well that allows passing extra args to the external frontend.
on it chief |
This fix allows building with a remote builder where frontend.dockerfile.v0 enabled = false in the buildkitd yaml file.
Note that this change only allows the usage of BUILDKIT_SYNTAX with a custom frontend image, and using the #syntax directive in this case will still fail.
Resolves: #3077