[wip] Update the --external-ca flag for swarm update/ca #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--external-ca value should take, and what protocol the external CA server should speak. Signed-off-by: Ying Li <ying.li@docker.com>
thaJeztah
changed the title
|
made it "wip" so that we don't merge before #1179 |
|
@thaJeztah thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As moby/swarmkit#2680 pointed out, the CLI documentation for the
--external-caflag indocker swarm updateanddocker swarm cais not very clear.This updates the docs and the CLI help to display the form the value should take, and what is required by the external CA server.
Note that this is dependent upon the design review of #1179.
Also, this does not add additional documentation for the
--external-caflag fordocker swarm init, due to moby/moby#33385