ssh options env var #1505
Open
ssh options env var #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Fernandes <andre@vertigo.com.br>
|
Resubmitted after major screwup on original PR. |
Codecov Report
@@ Coverage Diff @@
## master #1505 +/- ##
==========================================
- Coverage 55.14% 55.14% -0.01%
==========================================
Files 289 289
Lines 19371 19374 +3
==========================================
+ Hits 10683 10684 +1
- Misses 7996 7997 +1
- Partials 692 693 +1 |
AkihiroSuda
reviewed
Nov 9, 2018
| @@ -65,6 +74,9 @@ func (sp *sshSpec) Args() []string { | |||
| if sp.port != "" { | |||
| args = append(args, "-p", sp.port) | |||
| } | |||
| if sp.options != "" { | |||
| args = append(args, strings.Split(sp.options, " ")...) | |||
There was a problem hiding this comment.
maybe better to use https://godoc.org/github.com/google/shlex ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andre Fernandes andre@vertigo.com.br
Proposal: DOCKER_HOST_SSH_OPTIONS environment variable
What I did
The new "ssh://" protocol for DOCKER_HOST is great, but sometimes we need to use different ssh options than the default. A common scenario if the need to point to a project-specific ssh config file instead of the default one at "~/.ssh/config".
How I did it
An environment variable DOCKER_HOST_SSH_OPTIONS that can hold options for the ssh command docker uses when DOCKER_HOST contains the "ssh://" prefix.
How to verify it
export DOCKER_HOST_SSH_OPTIONS="-F /my/own/ssh.cfg"
export DOCKER_HOST="ssh://somehost"
docker version
Description for the changelog
DOCKER_HOST_SSH_OPTIONS to change ssh options when using "ssh://" protocol.