man/docker-build: fix/expand --build-arg #2012
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kolyshkin
commented
Jul 18, 2019
kolyshkin
commented
- Explain that variable value is optional and is taken from environment if not set.
- Clarify the meaning of ARG.
- Move example to the end.
Explain that variable value is optional and is taken from environment if not set. Clarify the meaning of ARG. Move example to the end. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
thaJeztah
requested changes
Oct 29, 2019
|
|
||
| These variables then are accessed like regular environment variables | ||
| in a `RUN` instruction of the Dockerfile. This mechanism is not meant | ||
| for passing secret values. |
There was a problem hiding this comment.
Perhaps we should also mention that if both an ENV, and an ARG is defined, that the ARG takes precedence and will override the value of the ENV.
While working on this, could you also update the online reference docs so that the descriptions match? https://github.com/docker/cli/blob/master/docs/reference/commandline/build.md#set-build-time-variables---build-arg
hc0503
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.