Skip to content

docs: document what AuthConfig.Auth is #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidhsingyuchen
Copy link

@davidhsingyuchen davidhsingyuchen commented Dec 7, 2022

PR enables folks to understand what Auth is without the need to trace code to:

// decodeAuth decodes a base64 encoded string and returns username and password
func decodeAuth(authStr string) (string, string, error) {

Signed-off-by: Hsing-Yu (David) Chen davidhsingyuchen@gmail.com

Signed-off-by: Hsing-Yu (David) Chen <davidhsingyuchen@gmail.com>
@davidhsingyuchen davidhsingyuchen marked this pull request as ready for review December 7, 2022 05:39
@thaJeztah
Copy link
Member

Thank you!

I want to double-check how this field is used, to be sure it's documented correctly as there's been some changes over time, and I'm not sure currently if this would always be username:password. These fields would be used to authenticate with different registries, and Authentication is not the same for all of them (which probably is one of the the reasons the field hasn't been documented so far).

I did a first search in history, but didn't completely finish that yet, but let me copy my notes here (in case I want to continue searching or someone else wants to);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants