chore: enable revive's conditions nesting related rules #6038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6038 +/- ##
=======================================
Coverage 58.91% 58.91%
=======================================
Files 358 358
Lines 29988 29985 -3
=======================================
- Hits 17666 17665 -1
+ Misses 11341 11340 -1
+ Partials 981 980 -1 🚀 New features to boost your workflow:
|
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
revive/if-else
branch
from
852c0f4 to
1b73902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
enable and fix revive's conditions nesting related rules
- How I did it
Add
early-return,if-return,indent-error-flowandsuperfluous-elserules to golangci-lint configuration and run golangci-lint, then apply preconisations- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
No